Conversation
Added `tests/buffer_size_test.rs` to verify that `DeflateEncoder` flushes data when the internal buffer exceeds the configured size. Fixed a bug in `src/compress/mod.rs` where `compress_loop` would return `InsufficientSpace` for empty inputs with `FlushMode::Finish` if the compressor wrote only bits (e.g., EOB marker) without advancing the byte output index. The fix ensures that both byte index and bit count are checked to detect progress. This ensures reliable stream termination and flushing behavior for custom buffer configurations. Co-authored-by: 404Setup <[email protected]>
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
1 participant
tests/buffer_size_test.rsto verifyDeflateEncoderflush behavior with custom buffer sizes.compress_loopinsrc/compress/mod.rswhere empty-input Finish blocks were incorrectly flagged asInsufficientSpacedue to ignoring bit-level writes.DeflateEncodercorrectly flushes to the underlying writer when the buffer limit is exceeded.PR created automatically by Jules for task 4127471986625588918 started by @404Setup